He-Pin opened a new pull request, #3391:
URL: https://github.com/apache/pekko/pull/3391
### Motivation
`BalancingDispatcher` has been deprecated since Akka 2.3 with the
recommendation to use `BalancingPool` instead. The
`BalancingDispatcherConfigurator` class remained public and unmarked. Since
Pekko 2.0.0 is a major release, it is time to deprecate and restrict visibility.
### Modification
- Add `@deprecated("Use BalancingPool instead of
BalancingDispatcherConfigurator", "Pekko 2.0.0")` annotation
- Mark the class as `private[pekko]` (INTERNAL API)
- Add `@nowarn("msg=deprecated")` to `BalancingPool` which uses the
configurator internally
- Update Scaladoc to indicate INTERNAL API
### Result
`BalancingDispatcherConfigurator` is no longer part of the public API.
`BalancingPool` continues to work as the supported replacement. Users who
referenced the configurator by full class name in config will still work
(reflection-based loading is unaffected by Scala access modifiers), but direct
code usage will produce deprecation warnings.
### Tests
- `sbt "actor-tests/Test/testOnly
org.apache.pekko.actor.dispatch.BalancingDispatcherSpec
org.apache.pekko.actor.dispatch.DispatchersSpec
org.apache.pekko.actor.ActorConfigurationVerificationSpec"` — 33 tests passed
- `sbt "actor-tests/Test/testOnly
org.apache.pekko.actor.dispatch.BalancingDispatcherModelSpec"` — 10 tests passed
- `sbt "actor-tests/Test/testOnly org.apache.pekko.actor.ActorMailboxSpec"`
— 33 tests passed
- `sbt "actor/mimaReportBinaryIssues"` — no issues
### References
Refs #3384, Refs #2168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
