pjfanning opened a new pull request, #906:
URL: https://github.com/apache/pekko-management/pull/906
5 fixes across 3 files (all in discovery-consul):
┌────────────────────────────────────────────┬──────────────────────────────────────────────────────┬──────────────────────────────────────────────────────────┐
│ Issue │ Fix
│ File(s)
│
├────────────────────────────────────────────┼──────────────────────────────────────────────────────┼──────────────────────────────────────────────────────────┤
│ Resource leak — Consul client (OkHttp │ CoordinatedShutdown task in
PhaseServiceUnbind calls │ ConsulServiceDiscovery.scala:54-59
│
│ pool, threads) never closed │ consul.destroy()
│
│
├────────────────────────────────────────────┼──────────────────────────────────────────────────────┼──────────────────────────────────────────────────────────┤
│ Blocking DNS on dispatcher — │ Moved to
DefaultBlockingDispatcherId via │
│
│ InetAddress.getByName blocks │ Future(...)(blockingEc)
│ ConsulServiceDiscovery.scala:80-82
│
│ system.dispatcher │
│
│
├────────────────────────────────────────────┼──────────────────────────────────────────────────────┼──────────────────────────────────────────────────────────┤
│ String concat in loop — prefix + name │ Hoisted to nameTag val before
the filter │ ConsulServiceDiscovery.scala:73
│
│ recomputed per service entry │
│
│
├────────────────────────────────────────────┼──────────────────────────────────────────────────────┼──────────────────────────────────────────────────────────┤
│ Unbounded N+1 queries — Future.sequence │ boundedTraverse batches by
lookup-parallelism │ ConsulServiceDiscovery.scala:79,101-111
│
│ fires all getService calls at once │ (default 8)
│
│
├────────────────────────────────────────────┼──────────────────────────────────────────────────────┼──────────────────────────────────────────────────────────┤
│ No HTTP timeouts — Consul client built │ connectTimeout, readTimeout,
writeTimeout wired to │ ConsulServiceDiscovery.scala:44-49,
│
│ with OkHttp defaults │ builder (default 10s each,
configurable) │ ConsulSettings.scala:34-44, reference.conf:27-37
│
└────────────────────────────────────────────┴──────────────────────────────────────────────────────┴──────────────────────────────────────────────────────────┘
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
