pjfanning opened a new pull request, #825: URL: https://github.com/apache/pekko-grpc/pull/825
Finding 26 — GrpcChannel.close(): Reversed to try close / finally deregister. The channel always gets closed even if deregistration throws. Order reversal is fine — closing the channel is the critical action, deregistration is cleanup. Finding 27 — onDownstreamFinish: Removed the isClosed(out) guard. Now call.cancel and completeStage() always run when downstream finishes. The null check on call guards against double-cancel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
