pjfanning commented on code in PR #349: URL: https://github.com/apache/pekko-persistence-dynamodb/pull/349#discussion_r3713329428
########## README.md: ########## @@ -6,10 +6,17 @@ A replicated Pekko Persistence journal backed by - This plugin implements both a journal as well as a snapshot store, - This includes a Pekko Persistence Query plugin. However, this requires an additional GSI for efficient usage. -Supported versions: -- Scala: `2.13.x`, `3.3.0+` +Apache Pekko Persistence DynamoDB 1.x Supported versions: +- Scala: `2.12.x`, `2.13.x`, `3.3.0+` - Pekko: `1.0.x+` +- Java: `8+` +- Amazon SDK for Java v1 + +Apache Pekko Persistence DynamoDB 2.x Supported versions: +- Scala: `2.13.x`, `3.3.0+` +- Pekko: `2.0.x+` - Java: `17+` +- Amazon SDK for Java v2 Review Comment: Thanks for @Mouwrice for the review. I think this particular change is correct. I will review your other issues and appreciate your input. * 1.x supports Scala 2.12 - https://github.com/apache/pekko-persistence-dynamodb/blob/1.1.x/build.sbt#L44 * the 1.x build is done with Java 8 * 1.x build has never been modified to test with Scala 3.8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
