pjfanning commented on code in PR #909: URL: https://github.com/apache/pekko-management/pull/909#discussion_r3719461995
########## management/src/main/scala/org/apache/pekko/management/PekkoManagementSettings.scala: ########## @@ -17,7 +17,9 @@ import java.net.InetAddress import java.util.Optional import scala.collection.immutable +import scala.concurrent.duration.FiniteDuration import scala.jdk.CollectionConverters._ +import scala.jdk.DurationConverters._ import scala.jdk.OptionConverters._ Review Comment: added a check for non-positive values -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
