raboof commented on code in PR #830:
URL: https://github.com/apache/pekko-grpc/pull/830#discussion_r3719738557
##########
runtime/src/main/resources/reference.conf:
##########
@@ -39,10 +39,10 @@ pekko.grpc.client."*" {
ssl-provider = ""
# Whether to verify the server's hostname against its TLS certificate (RFC
2818).
- # When false (the default), the client accepts any valid certificate
regardless
- # of hostname. This is insecure for production and should only be used for
testing.
+ # When false, the client accepts any valid certificate regardless of
hostname.
+ # This is insecure and should only be used for testing.
Review Comment:
(TBH there's scenario's where this is fine, but indeed that should be a
conscious operator decision)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
