The GitHub Actions job "Scalafmt" on pekko.git/feat/sink-watch-termination has failed. Run started by GitHub user He-Pin (triggered by He-Pin).
Head commit for run: df56648f25a24c545eeb8184e5be2d5d88f5cf4a / 虎鸣 <[email protected]> refactor: fuse InHandler into WatchedSinkLogic and use OptionVal Motivation: WatchedSinkLogic allocated an anonymous InHandler instance per materialization and used Option[Throwable] in the termination path, both causing unnecessary heap allocations. Modification: - Fuse the InHandler directly into WatchedSinkLogic (with InHandler), setting handlers(0) = this, following the established Pekko pattern used by CountSink, BroadcastSinkLogic, PartitionSinkLogic, etc. - Replace Option[Throwable] with OptionVal[Throwable] (value class) in upstreamFailureFromConnection to eliminate boxing on the termination signal path Result: One fewer anonymous class allocation per materialization and zero heap allocation in the termination signal path. Behavior unchanged. Tests: - sbt "stream-tests/Test/testOnly org.apache.pekko.stream.scaladsl.SinkWatchTerminationSpec" - 17/17 passed References: Refs #3409 Report URL: https://github.com/apache/pekko/actions/runs/31816715144 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
