The GitHub Actions job "Headers" on pekko-http.git/backport/locale-root-1.4.x has failed. Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run: d7258adf09b1022a1f8a274e65f7d6c6240605a9 / PJ Fanning <[email protected]> fix: use root locale when looking up a response header by name in RouteTest (#1223) Motivation: `RouteTest#header(name: String)` lowercased the given header name with the JVM default locale before comparing it to `HttpHeader#lowercaseName`, which is built with `toRootLowerCase`. Under a Turkish locale `"If-Match".toLowerCase` yields a dotless i, so the lookup silently returned `None` for any header name containing a capital `I`. The javadsl equivalent (`TestRouteResult`) already uses `toRootLowerCase`. Modification: Use `pekko.util.Helpers.toRootLowerCase` in `RouteTest#header(name)`. Result: Header lookup by name in the Scala testkit is locale independent and matches the javadsl behaviour. Tests: - sbt "http-testkit / Test / testOnly org.apache.pekko.http.scaladsl.testkit.ScalatestRouteTestSpec" - passes with the fix; the new test fails without it - scalafmt --mode diff-ref=origin/main - clean - sbt +mimaReportBinaryIssues - not run; method body change only, no API or binary shape change References: None - found while auditing the code base for locale sensitive lowercasing (cherry picked from commit 08e174c4ce2a1bf6c8371bf75e572093840bbd54) Report URL: https://github.com/apache/pekko-http/actions/runs/32722926236 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
