The GitHub Actions job "Headers" on pekko-persistence-dynamodb.git/copilot/update-aws-docs-references has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run: 1204ea99c90b3db0d6e4ad38dd2318c3ee7e2416 / PJ Fanning <[email protected]> Address review items from the AWS SDK v2 migration Motivation: Review of the SDK v1 to v2 migration turned up a Scala 3 deprecation, a region check that did not actually check anything, a README pointing at an extension point that does not exist, and pagination guards that are not equivalent to the ones they replaced. Modification: - Restore `private var reporter: ActorRef = null`; `= _` is deprecated from Scala 3.6 and warns on the 3.8.4 cross-build. - Validate the configured region against `Region.regions`. `Region.of` only rejects blank input, so the previous try/catch never fired for a typo. An unknown identifier is logged as a warning rather than failing the client build, since a region added after this SDK release is not in the built-in list. - Rewrite the README performance section. The plugin builds its own `DynamoDbAsyncClient` and does not expose the SDK HTTP client settings, so the advice to supply a custom client was not actionable. Record that `aws-client-config` is removed in 2.x and is silently ignored if left in `application.conf`. - Replace `hasLastEvaluatedKey` with a `nonEmptyKey` helper. The SDK method is true for an explicitly empty map, which would have thrown an NPE in `getAllRemainingQueryItems` and looped in the pagers. - Drop an unused `JMap` import and a no-op `s` interpolator. Result: No warnings on the 2.13 or 3.8.4 builds, a region typo is reported instead of surfacing later as a signing or DNS failure, and the README describes what the plugin actually supports. Tests: - sbt scalafmtCheckAll - pass - sbt compile Test/compile - pass on 2.13.18 and 3.8.4 - DynamoDB integration tests - Not run, Docker unavailable in this environment References: Refs #349 Report URL: https://github.com/apache/pekko-persistence-dynamodb/actions/runs/32787084786 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
