The GitHub Actions job "Validate and test" on pekko-http.git/feat/client-strict-response-entities has failed. Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run: 440b7f56a6cfdd9d7b0f925fff4fcb6c0e1a0640 / PJ Fanning <[email protected]> feat: extend strict response entities to the HTTP/2 client Motivation: `pekko.http.client.strict-response-entity-timeout` only affected the HTTP/1.1 client, so HTTP/2 users could not get the same behaviour. Modification: Move the strictify flow into `StreamUtils.strictifyResponseEntities`, taking a parallelism, and apply it in `Http2Blueprint.httpLayerClient` as well. The HTTP/1.1 client keeps parallelism 1, since responses on a connection are sequential anyway; the HTTP/2 client uses `max-concurrent-streams` so that a big response does not delay smaller ones on other streams. Document the HTTP/2 specific trade-offs in `reference.conf` and in the client configuration docs: responses are emitted in the order their entities complete, worst case memory is `max-concurrent-streams` * `strict-response-entity-max-bytes`, a failing entity fails the whole connection with every stream in flight on it, and entity data is read at the peer's pace rather than the application's. Result: The setting now covers both the HTTP/1.1 and the HTTP/2 client, with the HTTP/2 caveats spelled out. Tests: - sbt "http2-tests/testOnly org.apache.pekko.http.impl.engine.http2.Http2ClientSpec" - pass - sbt "http2-tests/testOnly org.apache.pekko.http.impl.engine.http2.Http2ClientServerSpec org.apache.pekko.http.impl.engine.http2.Http2PersistentClientTlsSpec org.apache.pekko.http.impl.engine.http2.Http2PersistentClientPlaintextSpec" - pass - sbt "http-core/testOnly org.apache.pekko.http.impl.engine.client.LowLevelOutgoingConnectionSpec org.apache.pekko.http.impl.engine.client.HttpConfigurationSpec" - pass - sbt http-core/mimaReportBinaryIssues - pass - sbt ++3.3.8 http-core/Test/compile http2-tests/Test/compile - pass - sbt docs/paradox - pass - scalafmt --list --mode diff-ref=upstream/main - no changes References: None - follow-up to the HTTP/1.1 support in the previous commit Report URL: https://github.com/apache/pekko-http/actions/runs/32838158254 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
