pjfanning opened a new pull request, #3479:
URL: https://github.com/apache/pekko/pull/3479

   ### Motivation
   
   Both remoting transports log when TLS is enabled but hostname verification is
   disabled, and both mark the message with `LogMarker.Security`. They disagree 
on
   the level:
   
   | Transport | Level |
   | --- | --- |
   | Artery (`artery/tcp/ConfigSSLEngineProvider.scala`) | `warning` |
   | Classic (`transport/netty/SSLEngineProvider.scala`) | `info` |
   
   `LogMarker.Security` is the marker the documentation tells operators to 
treat as
   security relevant, so logging it at `info` in classic remoting understates it
   and makes it easy to lose in startup output.
   
   ### Modification
   
   Log the classic remoting message at `warning`, matching artery. The message 
text
   and the `LogMarker.Security` marker are unchanged, and the artery side is
   untouched.
   
   ### Result
   
   Both transports report a disabled hostname verification at the same level.
   
   ### Tests
   
   `remote/Compile/compile` passes. No test asserts on this message or its 
level.
   
   ### References
   
   None - noticed while reviewing #3478


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to