pjfanning opened a new pull request, #3511:
URL: https://github.com/apache/pekko/pull/3511

   ### Motivation
   Review of the 1.7.x cherry-pick (#3501) found two comment issues in #3500 
that also apply to main:
   
   - In `reference.conf`, the new `serialization-max-nesting-depth` block was 
inserted between the `allow-java-serialization` doc comment and its setting, 
orphaning that comment.
   - `NestedDeserialization` uses a one-element `Array[Int]` in a `ThreadLocal` 
without explaining why.
   
   ### Modification
   Move `allow-java-serialization = off` back under its doc comment, placing 
the `serialization-max-nesting-depth` comment and setting after it, and add a 
code comment noting the `Array[Int]` avoids the boxing a `ThreadLocal[Int]` 
would incur.
   
   ### Result
   The `allow-java-serialization` comment is attached to its setting again, and 
the boxing rationale is recorded. No behavioral change; HOCON keys are 
order-independent.
   
   ### Tests
   - Not run - docs only (comment-only changes; `scalafmt` run on the changed 
Scala file)
   
   ### References
   Refs #3500, Refs #3501


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to