nvollmar commented on code in PR #3501: URL: https://github.com/apache/pekko/pull/3501#discussion_r3913611590
########## actor/src/main/scala/org/apache/pekko/serialization/NestedDeserialization.scala: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.pekko.serialization + +import java.io.NotSerializableException + +import org.apache.pekko.annotation.InternalApi + +/** + * INTERNAL API + * + * Bounds how deeply one deserialization may nest. + * + * Several wire formats carry a nested payload: the enclosed message is an opaque byte + * array that is deserialized in turn, and that payload may itself enclose another. Each + * level is parsed on its own, so a protobuf parser's nesting limit does not bound the + * chain - only the size of the message does. Recursion therefore tracks the nesting + * rather than the size of the message, and a sufficiently deep chain fails with a + * `StackOverflowError` instead of a serialization error. + * + * The depth is per thread because one message is deserialized synchronously on one thread. + */ +@InternalApi +private[pekko] object NestedDeserialization { + + private val depth = new ThreadLocal[Array[Int]] { + override def initialValue(): Array[Int] = new Array[Int](1) Review Comment: Maybe add a comment that Array[Int](1) is used to avoid boxing/unboxing int -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
