Adarsh-Me opened a new pull request, #1901:
URL: https://github.com/apache/pekko-connectors/pull/1901

   ## Motivation
   
   Fixes #1517.
   
   LocalStack images from 2026.3 onwards require an account and 
`LOCALSTACK_AUTH_TOKEN` (see #1517), so `localstack/localstack:latest` broke 
the `aws-spi-pekko-http` tests. The pin to `4.14` (#1518) is only a stopgap, 
and in #1517 the remaining options were listed as: a LocalStack account via ASF 
Infra, testing against real AWS, or finding other docker images.
   
   This PR takes the last option and removes LocalStack from the 
testcontainers-based tests entirely, using service-specific emulators that need 
no credentials:
   
   - **DynamoDB**: `TestDynamoDB` now runs against Amazon's official 
`amazon/dynamodb-local:3.3.1` image (port 8000).
   - **SNS**: `TestSNS` now runs against `pafortin/goaws:v0.3.1` (port 4100) — 
the same emulator already used for SNS in the repo's `docker-compose.yml`.
   
   `LocalstackBaseAwsClientTest` is replaced by 
`DynamoDBLocalBaseAwsClientTest` and `GoAwsSNSBaseAwsClientTest`, and the 
now-unused `LocalStackReadyLogWaitStrategy` is removed.
   
   Note: `docker-compose.yml` still pins `amazoneventbridge` to 
`localstack/localstack:0.10.7` (a pre-auth image, used for manual local runs 
only); I left that untouched since #1519 covers it.
   
   ## Verification
   
   Both migrated test classes were run locally against Docker Desktop with:
   
   ```
   sbt "aws-spi-pekko-http/testOnly 
org.apache.pekko.stream.connectors.awsspi.dynamodb.TestDynamoDB 
org.apache.pekko.stream.connectors.awsspi.sns.TestSNS"
   ```
   
   ```
   [info] TestDynamoDB:
   [info] DynamoDB
   [info] - should create a table (4 seconds, 642 milliseconds)
   [info] TestSNS:
   [info] Async SNS client
   [info] - should publish a message to a topic (464 milliseconds)
   [info] Tests: succeeded 2, failed 0, canceled 0, ignored 0, pending 0
   [info] All tests passed.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to