The GitHub Actions job "Binary Compatibility" on pekko.git/remove-akka26-manifest-compat has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run: af45d91cb469cb8203f8e4fb6a270b378dfcab82 / PJ Fanning <[email protected]> remove the Akka 2.6.4 rolling-migration manifests from ClusterMessageSerializer Motivation: The Old* and *Pre2523 manifest vals were kept "for one version iteration from Akka 2.6.4" to allow rolling migration to short manifests, removable "in Akka 2.6.6 or later". No peer a Pekko node can talk to emits them: Pekko has always emitted the short manifests, and an actual old Akka node would emit akka.cluster.* strings, which these org.apache.pekko.cluster.* constants (renamed in the fork) can never match. Each dead branch was a wire-reachable deserialization path. Modification: Remove the vals, their fromBinary cases, and the two heartbeat deserializers only those cases used. Replace the spec's old-manifest round-trip tests and their now-unused helpers with a test asserting every removed manifest is rejected as unknown. Result: The class-based manifests are refused with "Unknown manifest". Short manifests are unchanged. Tests: - sbt "cluster/testOnly org.apache.pekko.cluster.protobuf.ClusterMessageSerializerSpec" - 8 passed - the new rejection test fails without the production change (the manifest routes to deserializeJoin and raises InvalidProtocolBufferException) - sbt "cluster/mimaReportBinaryIssues" - no issues - sbt "cluster/scalafmtCheckAll" - clean References: None - removes dead Akka 2.6.4 compatibility code Report URL: https://github.com/apache/pekko/actions/runs/33734367739 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
