The GitHub Actions job "CI" on pekko-connectors.git/aws-spi-close-robustness has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run: b3478232afb2a9ea391e170ef0f8e8ad9705ed1f / PJ Fanning <[email protected]> AWS SPI: make close() non-throwing and give auto-created actor systems unique names Motivation: SdkAsyncHttpClient.close() is an AutoCloseable-style method; the builder's shutdown handle blocks with Await.result and could propagate a TimeoutException (or any termination failure) to SDK callers. Also, every client built without an explicit ActorSystem created a system named "aws-pekko-http", so multiple clients in one JVM produced identically named systems that are indistinguishable in logs and thread names. Modification: Catch NonFatal failures from the shutdown handle in close() and log a warning instead of throwing. Suffix auto-created actor system names with a monotonically increasing counter. Expose the client's actor system as private[awsspi] for tests. Result: close() never throws to SDK callers, and each auto-created client gets a uniquely named actor system. Tests: - sbt "aws-spi-pekko-http/Test/testOnly org.apache.pekko.stream.connectors.awsspi.PekkoHttpClientSpec" - 13 passed (2 new directional tests) - sbt "aws-spi-pekko-http/Test/testOnly ...RequestRunnerSpec ...PekkoHttpClientH1TestSuite" - 8 passed - sbt "aws-spi-pekko-http/mimaReportBinaryIssues" - no issues - scalafmt --mode diff-ref=origin/main - clean References: None - hardening found during a review of the aws-spi-pekko-http client Report URL: https://github.com/apache/pekko-connectors/actions/runs/33749568067 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
