nvollmar commented on code in PR #3515:
URL: https://github.com/apache/pekko/pull/3515#discussion_r3924525173


##########
serialization-jackson/src/main/resources/reference.conf:
##########
@@ -210,7 +210,10 @@ pekko.serialization.jackson {
     # payload that decompresses to more than this is rejected rather than
     # allocated, guarding against a small message that inflates without bound.
     # This applies on deserialization regardless of the `algorithm` setting 
above.
-    max-decompressed-size = 256 MiB
+    # The default of -1 applies no limit, preserving the behaviour of earlier
+    # releases; set a size such as `256 MiB` to bound decompression, choosing a
+    # value larger than any payload the system legitimately exchanges.
+    max-decompressed-size = -1

Review Comment:
   Pekko overall is a bit inconsistent in this, some settings use -1 for 
unlimited, some settings use 
   ```
   max-received-message-size = unlimited
   ```
   In general I find such keys more clear than using magic numbers like -1 or 0 
that change the meaning of the setting.
   
   Maybe something we can address in 2.0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to