The GitHub Actions job "Nightly Builds (1.7)" on pekko.git/main has failed. Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run: 4efa8195a59f61969a45c20a27e8993c8d6d9939 / PJ Fanning <[email protected]> test: cover the per-stream frame-size bound in TcpFraming (#3524) Motivation: TcpFraming.ReadStreamId selects maximumLargeFrameSize only for ArteryTransport.LargeStreamId and maximumFrameSize otherwise (#3492), but no test exercised that selection: the existing bound tests all use a single maximumFrameSize with no maximumLargeFrameSize configured, so they cannot tell the per-stream selection apart from a bug that applied one bound to every stream. Modification: Add a perStreamBoundedFramingFlow fixture with distinct maximumFrameSize and maximumLargeFrameSize, and two tests: a frame over the ordinary maximum but within the large maximum is accepted on ArteryTransport.LargeStreamId and rejected on ArteryTransport.OrdinaryStreamId. Both frames carry their full declared payload, so a false accept cannot hide behind truncation. Result: The per-stream bound selection in ReadStreamId is covered directly. Tests: - sbt "remote/testOnly org.apache.pekko.remote.artery.tcp.TcpFramingSpec" - 16 passed - Checked the new tests discriminate: with ReadStreamId's selection replaced by an unconditional maximumLargeFrameSize, the ordinary-stream test fails ("Future.failed not completed with a throwable") while the large-stream test still passes; reverted after confirming - sbt "remote/scalafmtCheckAll" - clean References: None - test-coverage gap noticed while comparing TcpFraming.scala (hardened in #3492) against an unrelated Akka fix for the same class of issue Report URL: https://github.com/apache/pekko/actions/runs/33823346009 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
