nvollmar commented on code in PR #478:
URL:
https://github.com/apache/pekko-persistence-cassandra/pull/478#discussion_r3943746788
##########
core/src/main/resources/reference.conf:
##########
@@ -250,6 +250,23 @@ pekko.persistence.cassandra {
# size and this should be reduced if that warning is seen.
max-message-batch-size = 150
+ # Hard upper bound on the number of events buffered by a single tag writer.
+ # Set to 0 (the default) for no limit, which is the behaviour of earlier
versions.
+ #
+ # Normal writes are already bounded: the journal waits for the tag write
to be
+ # acknowledged, so a persistent actor has at most one write outstanding.
Recovery
+ # sends tag writes without waiting for acknowledgement, so a persistence
id with a
+ # lot of tagged events to replay is what can make this buffer grow.
+ #
+ # When the limit is reached the tag write is rejected and the failure is
returned to
+ # the journal, which fails the write for that persistent actor. Nothing is
silently
+ # dropped: rejected events consume no tag pid sequence nrs and are written
by tag
+ # scanning when the persistent actor next recovers. Enable this only if an
unbounded
+ # buffer is an actual risk for you, as the rejection stops persistent
actors.
+ #
+ # Should be comfortably larger than max-message-batch-size.
+ max-buffer-size = 0
Review Comment:
maybe also support `unlimited`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
