The GitHub Actions job "CI" on pekko-connectors.git/google-credentials-close has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run: b5682a66fa9ce98de432ee6cfc3f560ca51087ea / PJ Fanning <[email protected]> Google: allow OAuth2 credentials to be closed OAuth2Credentials materialises a Source.actorRef in its constructor to cache and refresh access tokens, and both the completion and failure matchers were PartialFunction.empty, so no message could ever stop it. Credentials read through GoogleExt are cached per ActorSystem and go away with it, but anyone building GoogleSettings directly from a Config - one set of credentials per tenant, say - leaked an actor and a materialised stream per instance with no way to reclaim them. Add Credentials.close(), a no-op by default, overridden in OAuth2Credentials to send a new Close command that the completion matcher turns into CompletionStrategy.draining, so requests already queued are still served. Requests made after close fail with an IllegalStateException rather than hanging on a promise nothing will complete, and closing twice is a no-op. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Report URL: https://github.com/apache/pekko-connectors/actions/runs/34048452861 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
