The GitHub Actions job "Unit Tests" on pekko-persistence-cassandra.git/resource-leak-migration-close has failed. Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run: 18ee1b008eb7f2a2e26bc325f77d707e3df4181c / PJ Fanning <[email protected]> Add EventsByTagMigration.close to release its tag writers actor Motivation: EventsByTagMigration starts a top level tag writers actor in its constructor and offers no way to stop it, so the actor and its TagWriter children stay alive for the lifetime of the ActorSystem after the migration has finished. The actor was also anonymous, which makes it hard to identify in logs. Modification: Give the tag writers actor a stable name, in the same style as the one Reconciliation starts, and add `EventsByTagMigration.close()` to stop it. Result: Callers can release the actor once the migration has completed, and the actor is recognisable in logs and actor paths. Tests: - sbt "core/Test/testOnly org.apache.pekko.persistence.cassandra.EventsByTagMigrationCloseSpec" - passed (new spec, no Cassandra needed) - sbt "core/mimaReportBinaryIssues" - passed - scalafmt --mode diff-ref=upstream/main --list - no changes needed - sbt "core/Test/testOnly org.apache.pekko.persistence.cassandra.EventsByTagMigrationSpec" - aborted, no local Cassandra (docker not running) References: None - resource leak found while auditing actor and session lifecycles Report URL: https://github.com/apache/pekko-persistence-cassandra/actions/runs/34058868422 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
