He-Pin commented on code in PR #3507:
URL: https://github.com/apache/pekko/pull/3507#discussion_r3947121910
##########
remote/src/main/scala/org/apache/pekko/remote/serialization/ArteryMessageSerializer.scala:
##########
@@ -182,15 +182,36 @@ private[pekko] final class ArteryMessageSerializer(val
system: ExtendedActorSyst
create: (UniqueAddress, CompressionTable[T]) => U): U = {
val protoAdv =
ArteryControlFormats.CompressionTableAdvertisement.parseFrom(bytes)
+ // the two lists are parallel; `zip` on its own would drop the tail of the
longer one and
+ // build a table the sender did not advertise, which is then acknowledged
as accepted
+ if (protoAdv.getKeysCount != protoAdv.getValuesCount)
Review Comment:
This branch conflicts with `main`: #3521 landed the `maxEntries` bound at
exactly this point in `deserializeCompressionAdvertisement`, and
`ArteryMessageSerializerSpec.scala` conflicts too. It needs a rebase before it
can merge. The two checks coexist fine — put this one after the `maxEntries`
check so the cheap entry-count bound runs first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
