The GitHub Actions job "MiMa Check" on pekko-management.git/update/sbt-mima-plugin-1.2.0 has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run: 2ee999b902bc3ceb92f325753f4a7bb87ed9c523 / PJ Fanning <[email protected]> Add MiMa excludes for the internal LeaseActor Motivation: MiMa 1.2.0 reports four problems in pekko-lease-kubernetes against the 1.0.0 baseline that MiMa 1.1.6 did not: LeaseActor.props and the LeaseActor constructor lost their four-argument forms when heartbeatMaxRetries and releaseMaxRetries were added in #911, and the forwarder for the deprecated FSM.setTimer that LeaseActor inherited from LoggingFSM (with its setTimer$default$4) is no longer emitted. LeaseActor is private[pekko] internal API, so none of these are part of the public surface, but the check fails the build. Modification: Add lease-actor-internal.backwards.excludes under lease-kubernetes/src/main/mima-filters/2.0.x.backwards.excludes with the four DirectMissingMethodProblem filters MiMa suggests, and a comment recording why each one is safe. Result: mimaReportBinaryIssues passes on all cross-built Scala versions with sbt-mima-plugin 1.2.0. Tests: - sbt "+mimaReportBinaryIssues" - success on 2.13.18, 3.3.8 and 3.9.0 - sbt headerCheckAll - success - No Scala sources changed, so no directional test is added References: Refs #967, Refs #911 Report URL: https://github.com/apache/pekko-management/actions/runs/34271246945 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
