The GitHub Actions job "Validate and test" on pekko-persistence-r2dbc.git/persistence-journal-batching has failed. Run started by GitHub user minjibir (triggered by minjibir).
Head commit for run: 8a91cdffaf41457a703f18120a5210645916fb6c / Jabir Minjibir <[email protected]> fix: address review feedback on batched write journal (#471) Motivation: Review feedback on #489 flagged blockers and cleanups. This commit also restores an incremental review history by keeping the original commit intact and applying the fixes on top. Modification: - Bound the write queue with max-queue-size and reject writes on overflow (A1). - Complete batch promises before publishing (A2); remove the implicit Array-to-Seq copy from the flush hot path (A3). - Require the postgres or yugabyte dialect at startup (A4). - Move the plugin to its own batched-journal config id that inherits from journal, so it can run side by side with the default journal and the batch keys no longer leak into the default journal settings (A5, B5). - Handle Flush without dead letters (B1); suppress WriteFinished and FlushDone sends during shutdown (C). - Restore the Lightbend copyright header on the derived file and revert all changes to existing classes and local build files so the PR is purely additive. - Add fail-fast and queue-limit specs, plus docs for the plugin id, the worst-case bisection cost, and the per-request event count. Result: The PR diff against main is insertions only: new class, new specs, one additive reference.conf block, and docs. Reviewers can diff 87df38e..HEAD to see just this delta. Tests: - sbt "core / Test / testOnly org.apache.pekko.persistence.r2dbc.journal.R2dbcBatchJournal*" (75 tests, live PostgreSQL) - sbt +headerCheckAll - sbt scalafmtCheckAll - sbt +mimaReportBinaryIssues - sbt docs/paradox - validatePullRequest task not present on this branch; equivalents run manually References: Refs #471 Report URL: https://github.com/apache/pekko-persistence-r2dbc/actions/runs/34407382088 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
