The GitHub Actions job "Validate and test" on pekko-http.git/fix-parser-settings-mima has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run: 56542494944066709f201b4d4333bc68c751d939 / PJ Fanning <[email protected]> fix: filter the ParserSettingsImpl accessors shifted by max-part-count Motivation: `maxPartCount` was added as the 12th field of `ParserSettingsImpl`, which shifted every positional case class accessor after it by one. MiMa checks `pekko-http-core` against 1.0.0, and the existing filters covered the positions that had already moved (12-21, 24, 26) but not 22 and 25, whose result types now differ from 1.0.0. `Check / Binary Compatibility` and `validatePullRequest` therefore fail on main for every PR: Scala 2.13 reports `copy$default$22` and `copy$default$25`, and Scala 3 additionally reports the `_22` and `_25` accessors. Modification: Add the four missing `IncompatibleResultTypeProblem` filters to `max-part-count.excludes`, the file introduced by the change that caused the shift, with a comment recording why those two positions moved. Result: `http-core/mimaReportBinaryIssues` passes again on Scala 2.13 and Scala 3, unblocking MiMa validation for open PRs. `ParserSettingsImpl` is `@InternalApi private[pekko]`, so the shifted synthetic accessors are not part of the public API. Tests: - sbt "http-core/mimaReportBinaryIssues" - success (Scala 2.13.18) - sbt "++3.3.8" "http-core/mimaReportBinaryIssues" - success (Scala 3.3.8) No test sources changed - this is a MiMa filter-only change. References: - https://github.com/apache/pekko-http/actions/runs/34544677238/job/103094612413 - Shift introduced by #1266 (feat: bound the number of parts in a multipart entity) Report URL: https://github.com/apache/pekko-http/actions/runs/34546273123 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
