minjibir commented on PR #489:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/489#issuecomment-5639230914
> @minjibir I won't further review this until you look at my pre-existing
review items posted on this PR.
@pjfanning I apologize for the sloppiness. I pushed three commits on top of
446fbcb
(a plain fast-forward, no rewrite; reviewers can diff 446fbcb..d3a3b48):
- 156f6a6 removes the Lightbend copyright block from
R2dbcBatchJournal.scala, so
every new file carries the standard header. sbt +headerCheckAll passes.
- d3a3b48 pends the batched journal suites on the MySQL jobs instead of
failing
on the dialect require; R2dbcBatchJournalMysqlDialectSpec stays ungated
since
it asserts that require. 75/75 on live PostgreSQL.
- 946f793 syncs the branch with latest main.
The B2/B3/B4/C points stand as explained in my previous comment; tell me if
you
want changes there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
