The GitHub Actions job "Nightly Build and Test" on pekko-connectors-kafka.git/main has failed. Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run: 7f8690cafbc6d3ff2f408d4b295a16392a184ba8 / PJ Fanning <[email protected]> use lazy slf4j placeholder logging in main sources (#653) Motivation: Several log calls in main sources built their message with Scala string interpolation, so the message was formatted even when the level was disabled. A few others used an `s` prefix with no substitutions at all. Modification: Converted the slf4j call sites in `testkit` to `{}` placeholders so the arguments are only rendered when the level is enabled - this matters most in `KafkaTestKitChecks.periodicalCheck`, which called `ex.getClass.getName` and `ex.getMessage` on every failed poll of a retry loop. Dropped the redundant `s` prefix on interpolation-free literals in `TransactionalSources` and `KafkaConsumerBenchmarks`. Replaced the manual `isDebugEnabled` guard in `KafkaConsumerActor` with a placeholder call, since the logging adapter already checks the level before formatting. Left unchanged: `KafkaClusterSharding` and `KafkaContainerCluster` already use placeholders, the `benchmarks` module's scala-logging `LazyLogging` macros already wrap interpolation in a level check, and the `Partitions drained` calls in `TransactionalSources` would evaluate `mkString` eagerly either way and would change their rendered output if the collection were passed through the adapter instead. Result: No message or argument is rendered unless the log level is enabled, and no call site pays for interpolation it does not use. Log output text is unchanged. Tests: - sbt "core/compile" "testkit/compile" "benchmarks/compile" - success (Scala 2.13.18) - sbt "++3.3.8 core/compile" "++3.3.8 testkit/compile" - success (Scala 3.3.8) - sbt "core/scalafmtCheck" "testkit/scalafmtCheck" "benchmarks/scalafmtCheck" - success - sbt "core/mimaReportBinaryIssues" "testkit/mimaReportBinaryIssues" - success - No directional test added: this changes only the shape of logging calls, with no behavior or API change. References: None - logging cleanup found while reviewing main sources Report URL: https://github.com/apache/pekko-connectors-kafka/actions/runs/34732261461 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
