liloew commented on PR #1971:
URL:
https://github.com/apache/pekko-connectors/pull/1971#issuecomment-5946026002
Thanks for the feedback. I have updated the PR to address the concerns:
- Added documentation describing the compatibility issue with S3-compatible
services such as Huawei OBS and Tencent COS.
- Documented the `signing.path-encoded-characters` configuration and its
programmatic equivalent.
- Added `S3SettingsSpec` cases covering:
- the default configuration;
- reading a custom value from configuration;
- an empty configured value;
- rejection of values containing `/`.
- Added `CanonicalRequestSpec` cases proving that:
- the default reserved characters are encoded;
- a custom character set changes the canonical path;
- an empty character set leaves path characters unencoded.
- Added validation and updated the reference configuration comments to
clarify that this setting should only be changed for services whose signing
behavior differs from AWS S3.
These tests demonstrate that changing the configured character set changes
the canonical request path as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
