pjfanning opened a new pull request, #1323:
URL: https://github.com/apache/pekko-http/pull/1323

   ### Motivation
   Addresses the non-blocking points in 
https://github.com/apache/pekko-http/pull/1316#issuecomment-5887566762.
   
   ### Modification
   - `reference.conf`: the `max-connection-age` comment now also states the 
converse case, that a later `terminate` with an earlier deadline shortens a 
drain started by the age (also when `max-connection-age-grace` is `infinite`). 
This mirrors `http2.md`.
   - `Http2ServerSpec`: new test for `max-connection-age-grace = infinite` 
followed by a later `terminate(10.millis)`. The connection stays open while 
draining, then closes within the terminate deadline.
   - `Http2ServerSpec`: wider timing margins. The age test now uses a 1s age 
with `expectNoBytes(700.millis)` (was 500ms / 400ms). The "not shorten" test 
now uses `terminate(2.seconds)` with `expectNoBytes(700.millis)` (was 1s / 
700ms).
   
   ### Result
   The docs and tests cover both directions of the age/terminate interaction, 
and the timing-sensitive tests have more headroom on CI.
   
   ### Tests
   - `sbt "http2-tests/testOnly 
org.apache.pekko.http.impl.engine.http2.Http2ServerSpec -- -z 
max-connection-age"`: 7 tests pass
   - `scalafmt` run on the changed spec
   
   ### References
   Refs #1316
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to