The GitHub Actions job "CI" on pekko-connectors.git/main has succeeded.
Run started by GitHub user pjfanning (triggered by pjfanning).

Head commit for run:
2df2513ab778c0e43c5498cbdfcbba47390f7364 / PJ Fanning 
<[email protected]>
S3: address review comments on path-encoded-characters

Motivation:
Remaining review comments on the configurable path encoding: the key in
reference.conf made the setting always present, the docs example value
did the opposite of what was described, and the Signer import was out
of order.

Modification:
Comment out `signing.path-encoded-characters` in reference.conf so an
unset value really means "use the RFC 3986 default". Correct the docs
and reference.conf to recommend ":?#[]$'()*+=" for Huawei OBS and
Tencent COS based on the reported test matrix. Fix the Signer import
grouping and minor typos.

Result:
The default-settings spec passes and the documented value matches the
observed vendor behaviour.

Tests:
sbt "s3/testOnly *CanonicalRequestSpec *SignerSpec *S3SettingsSpec"
sbt "s3/mimaReportBinaryIssues"

Report URL: https://github.com/apache/pekko-connectors/actions/runs/38278915183

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to