The GitHub Actions job "Pull Requests" on pekko.git/zstd-compression has failed.
Run started by GitHub user pjfanning (triggered by pjfanning).

Head commit for run:
d2cdcae160e018e1af632a564f02d1d0d10f9044 / PJ Fanning 
<[email protected]>
Remove the zstd-jni default from ZstdDecompressor

Motivation:
ZstdDecompressor's maxBytesPerChunk defaulted to Zstd.blockSizeMax(), the only
zstd default not taken from the documented Compression constants. The gzip and
deflate decompressor stages have no default, and every caller passes the value.

Modification:
Make maxBytesPerChunk a required parameter of ZstdDecompressor.

Result:
ZstdDecompressor matches the other decompressor stages, and callers pick the
chunk size explicitly (Compression.zstdDecompress already does).

Tests:
sbt "stream/scalafmt" "stream-tests/testOnly 
org.apache.pekko.stream.io.compression.*"
(145 succeeded, 0 failed)

References:
Review comment https://github.com/apache/pekko/pull/3639#issuecomment-6347243585

Report URL: https://github.com/apache/pekko/actions/runs/39826104857

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to