pjfanning opened a new pull request, #3645: URL: https://github.com/apache/pekko/pull/3645
### Motivation `ClusterShardingSpec` has a commented-out block with a FIXME. It was meant to check that `ActorContext.ask` compiles when the request message takes more than one parameter. It was disabled because it did not compile with an early Scala 2.13 milestone. The `ActorContext.ask` signature has changed since then, but the check was never turned back on. ### Modification Turn the block back on in the "EntityRef - ActorContext.ask" test. It now uses the current `ctx.ask[Req, Res](target, createRequest)` signature with a `WhoAreYou2(17, _)` request to the sharded entity ref. ### Result The tests again check that `ActorContext.ask` accepts request factories for messages with several parameters. The stale FIXME is gone. ### Tests - Not run locally - left to CI ### References Ported from (Apache-2.0 since 2026-10-23): - https://github.com/akka/akka-core/pull/32174 ### Notes for reviewers - Test-only change, so there are no binary compatibility concerns. - The behavior is only built inside `Behaviors.setup` and never spawned. It is a compile-time check, as the original block intended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
