He-Pin commented on code in PR #3644:
URL: https://github.com/apache/pekko/pull/3644#discussion_r4355860977
##########
cluster-sharding/src/test/scala/org/apache/pekko/cluster/sharding/ClusterShardingInternalsSpec.scala:
##########
@@ -98,10 +98,11 @@ class ClusterShardingInternalsSpec extends PekkoSpec("""
val handOffStopper = system.actorOf(
Props(new HandOffStopper(typeName, shard, probe.ref,
Set(emptyHandlerActor), HandOffStopMessage, 10.millis)))
+ // the entity stop timeout is at least 1 second
Review Comment:
The production fix looks correct, but increasing this upper waiting limit
also accepts the old behavior. Please add a directional regression that asserts
the corrected remaining-time warning and cancellation of the pending warning in
`ShardRegion.scala:566,576`, preferably with controlled scheduling. The
regression should expose the original issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
