He-Pin commented on code in PR #3647: URL: https://github.com/apache/pekko/pull/3647#discussion_r4355861894
########## stream-tests/src/test/scala/org/apache/pekko/stream/MaterializerWithAttributesSpec.scala: ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ Review Comment: This new file adapts `AttributesSource` and `StreamActor` from the [Akka source](https://github.com/akka/akka-core/blob/bf20e967571574994ccb3cae411401f5a9021ab9/akka-stream-tests/src/test/scala/akka/stream/MaterializerWithAttributesSpec.scala#L1-L67), which carries a 2023 Lightbend copyright notice. Please retain that source notice through the project header workflow and rerun the header checks. ########## docs/src/main/paradox/stream/stream-flows-and-basics.md: ########## @@ -384,7 +387,7 @@ and emitting the "materialized value". An @apidoc[actor.ActorSystem] wide `Mater @apidoc[SystemMaterializer] by @scala[having an implicit `ActorSystem` in scope]@java[passing the `ActorSystem` to the various `run` methods] this way there is no need to worry about the `Materializer` unless there are special requirements. -The use case that may require a custom instance of `Materializer` is when all streams materialized in an actor should be tied to the Actor lifecycle and stop if the Actor stops or crashes. +One use case that may require a custom instance of `Materializer` is when all streams materialized in an actor should be tied to the Actor lifecycle and stop if the Actor stops or crashes. Review Comment: Please remove the trailing space on this line; `git diff --check` currently exits 2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
