He-Pin commented on code in PR #3648:
URL: https://github.com/apache/pekko/pull/3648#discussion_r4357240093
##########
coordination/src/main/scala/org/apache/pekko/coordination/lease/LeaseUsageSettings.scala:
##########
@@ -19,9 +19,38 @@ import scala.jdk.DurationConverters._
import org.apache.pekko
import pekko.util.PrettyDuration._
-final class LeaseUsageSettings private[pekko] (val leaseImplementation: String,
- val leaseRetryInterval: FiniteDuration) {
+/**
+ * Note that if you define a custom lease name and have several Cluster
Singletons or Cluster Sharding
Review Comment:
Post-merge follow-up: the copied lease-name implementation and contract text
still have only the older source notices ending in 2022. The corresponding
upstream files carry these notices:
-
[LeaseUsageSettings.scala](https://github.com/akka/akka-core/blob/f3bb544cf78bf9fdeb6bd6d5800450d3078a4d20/akka-coordination/src/main/scala/akka/coordination/lease/LeaseUsageSettings.scala#L1-L4):
`Copyright (C) 2019-2023 Lightbend Inc. <https://www.lightbend.com>`
-
[Shard.scala](https://github.com/akka/akka-core/blob/f3bb544cf78bf9fdeb6bd6d5800450d3078a4d20/akka-cluster-sharding/src/main/scala/akka/cluster/sharding/Shard.scala#L1-L4):
`Copyright (C) 2009-2023 Lightbend Inc. <https://www.lightbend.com>`
-
[ClusterSingletonManager.scala](https://github.com/akka/akka-core/blob/f3bb544cf78bf9fdeb6bd6d5800450d3078a4d20/akka-cluster-tools/src/main/scala/akka/cluster/singleton/ClusterSingletonManager.scala#L1-L4):
`Copyright (C) 2009-2023 Lightbend Inc. <https://www.lightbend.com>`
- [Typed
ClusterShardingSettings.scala](https://github.com/akka/akka-core/blob/f3bb544cf78bf9fdeb6bd6d5800450d3078a4d20/akka-cluster-sharding-typed/src/main/scala/akka/cluster/sharding/typed/ClusterShardingSettings.scala#L1-L4):
`Copyright (C) 2017-2023 Lightbend Inc. <https://www.lightbend.com>`
- [Classic
ClusterShardingSettings.scala](https://github.com/akka/akka-core/blob/f3bb544cf78bf9fdeb6bd6d5800450d3078a4d20/akka-cluster-sharding/src/main/scala/akka/cluster/sharding/ClusterShardingSettings.scala#L1-L4):
`Copyright (C) 2015-2023 Lightbend Inc. <https://www.lightbend.com>`
-
[ClusterSingleton.scala](https://github.com/akka/akka-core/blob/f3bb544cf78bf9fdeb6bd6d5800450d3078a4d20/akka-cluster-typed/src/main/scala/akka/cluster/typed/ClusterSingleton.scala#L1-L4):
`Copyright (C) 2009-2023 Lightbend Inc. <https://www.lightbend.com>`
Please preserve these exact source notices alongside the existing notices in
a focused follow-up and run the header checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
