He-Pin commented on code in PR #3652:
URL: https://github.com/apache/pekko/pull/3652#discussion_r4357239871
##########
remote/src/main/scala/org/apache/pekko/remote/artery/ArteryTransport.scala:
##########
@@ -1103,4 +1119,22 @@ private[remote] object ArteryTransport {
case _ => "message"
}
+ /**
+ * Generates the system uid from the bind hostname and port in combination
with timestamps,
+ * which makes collisions between systems less likely than with a plain
random number.
+ */
+ def generateSystemUid(hostname: String, port: Int, timestamp1: Long): Long =
{
Review Comment:
Please retain the source copyright notices for the copied code in this PR.
For example, `generateSystemUid` copies the upstream hash/timestamp algorithm,
but this file still has only the older notice ending in 2022. The same omission
is present in these adapted files:
-
[ArteryTransport.scala](https://github.com/akka/akka-core/blob/cc8a64ce2c7d2a808c46fddc3c9cc354ae6d48a5/akka-remote/src/main/scala/akka/remote/artery/ArteryTransport.scala#L1-L4):
`Copyright (C) 2016-2023 Lightbend Inc. <https://www.lightbend.com>`
-
[RemoteConnectionSpec.scala](https://github.com/akka/akka-core/blob/85236f87494573b08c1cf52b7f123d886632925a/akka-remote/src/test/scala/akka/remote/artery/RemoteConnectionSpec.scala#L1-L4):
`Copyright (C) 2009-2023 Lightbend Inc. <https://www.lightbend.com>`
-
[ActorSystem.scala](https://github.com/akka/akka-core/blob/cc8a64ce2c7d2a808c46fddc3c9cc354ae6d48a5/akka-actor/src/main/scala/akka/actor/ActorSystem.scala#L1-L4):
`Copyright (C) 2009-2023 Lightbend Inc. <https://www.lightbend.com>`
-
[Handshake.scala](https://github.com/akka/akka-core/blob/85236f87494573b08c1cf52b7f123d886632925a/akka-remote/src/main/scala/akka/remote/artery/Handshake.scala#L1-L4):
`Copyright (C) 2016-2023 Lightbend Inc. <https://www.lightbend.com>`
-
[Slf4jLogger.scala](https://github.com/akka/akka-core/blob/cc8a64ce2c7d2a808c46fddc3c9cc354ae6d48a5/akka-slf4j/src/main/scala/akka/event/slf4j/Slf4jLogger.scala#L1-L4):
`Copyright (C) 2009-2023 Lightbend Inc. <https://www.lightbend.com>`
Please add these source notices alongside the existing notices through the
project header workflow, and run the header checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
