The GitHub Actions job "Pull Requests" on pekko.git/artery-uid-collision has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run: 5f0f469b654a1efe8a9b8b858703b534009ea5be / PJ Fanning <[email protected]> test: assert the Artery uid collision warning and use probe timeouts Motivation: Review of #3652 noted that EventFilter[UidCollisionException]() does not assert a collision: it matches Error events with that exception and allows any number of them, while the collision is logged as a Warning without the exception. The collision tests also still used explicit 500 ms deadlines, which the Akka 2.9.0 follow-up (akka-core#32177) replaced with the configured probe timeout, and the adapted files kept their older Lightbend notices. Modification: - Subscribe a probe to Warning events and expect a "UID collision" warning after each collision step. Handshake retries can log the collision more than once, so the tests expect at least one. - Use the default probe timeout for the eight round trips in the two collision tests; the retry-polling tests keep their deadlines. - Update the Lightbend notices of the files adapted from Akka 2.9.0 to the 2023 source notices. Result: Removing the collision warning makes both collision tests fail. Tests: sbt "remote/testOnly org.apache.pekko.remote.artery.RemoteConnectionSpec org.apache.pekko.remote.artery.SystemUidSpec" (9 passed; both collision tests fail with the warning removed) sbt "actor/headerCheckAll" "remote/headerCheckAll" "slf4j/headerCheckAll" References: https://github.com/apache/pekko/pull/3652 Report URL: https://github.com/apache/pekko/actions/runs/39932797620 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
