He-Pin commented on PR #1368: URL: https://github.com/apache/pekko-http/pull/1368#issuecomment-6370017699
LGTM. `PersistentConnection` is `private[http2]`, so no binary-compat impact. Emitting the 503 (carrying the request attributes for correlation) before `failStage` is correct — `requestIn`/`responseOut` are stage ports in scope, matching the existing `emitMultiple(responseOut, …)` pattern, and `emit` defers the failure until the response is delivered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
