He-Pin commented on PR #1369: URL: https://github.com/apache/pekko-http/pull/1369#issuecomment-6370018501
LGTM. The idle-timeout layer collapses to `BidiFlow.identity` when both timeouts are `infinite` (the default), so there is zero overhead unless opted in. Placement above masking / below frame handling means Pong replies count as activity (verified by the directional test), and the nanoTime difference comparison is wraparound-safe. Making `WebSocketIdleTimeoutException` a plain `RuntimeException` (not a `TimeoutException`) correctly avoids the client TCP layer rewriting it into a TCP idle timeout. The MiMa excludes match the established precedent for settings additions on `@DoNotInherit` traits (javadsl declares 4 abstract methods, scaladsl re-declares 2). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
