pjfanning opened a new issue, #928:
URL: https://github.com/apache/pekko-grpc/issues/928

   The pekko-http client backend enforces deadlines only on the client side 
(`PekkoHttpClientUtils.applyDeadline`). `GrpcRequestHelpers` doesn't send a 
`grpc-timeout` header, so the server never learns the deadline.
   
   The Netty backend does send it, because grpc-java adds it from the call's 
deadline.
   
   Proposal: when a call has a deadline (from `GrpcClientSettings.deadline` or 
the per-call `setDeadline`, #922), send `grpc-timeout` with the time remaining 
at invoke time, encoded as in 
https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md.
   
   Tests: a server sees the header for pekko-http clients, the same as for 
Netty clients.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to