The GitHub Actions job "Pull Requests" on pekko.git/fix-3686-handoff-awaiting-lease has succeeded. Run started by GitHub user He-Pin (triggered by He-Pin).
Head commit for run: 406d22c73ef76c8b2400b62dd8b77618297045aa / 虎鸣 <[email protected]> fix: complete HandOff while a Shard is awaiting its lease Motivation: Shard.awaitingLease stashes every message that is not lease- or membership-related, including HandOff. Because a failed lease acquisition is retried indefinitely, the coordinator never receives ShardStopped and a rebalance cannot complete while the lease backend is unavailable. Modification: Handle HandOff in awaitingLease by delegating to the regular handOff path. A shard awaiting its lease has not sent ShardInitialized and hosts no entities, so handOff replies ShardStopped immediately and stops the shard. Result: A rebalance can complete even while the shard lease is unobtainable. Tests: - sbt "cluster-sharding / Test / testOnly org.apache.pekko.cluster.sharding.ShardWithLeaseSpec": 6/6 passed - Reverted the fix and re-ran the new test only: failed as expected (directional) References: Fixes #3686 Report URL: https://github.com/apache/pekko/actions/runs/40108883203 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
