The GitHub Actions job "Pull Requests" on pekko.git/fix-3690-handshake-pending-message has succeeded. Run started by GitHub user He-Pin (triggered by He-Pin).
Head commit for run: cab04642f1cd1804c2ec3fa68d3e3c9d03055838 / 虎鸣 <[email protected]> fix: do not drop the pending message in OutboundHandshake.postStop Motivation: OutboundHandshake holds an already-grabbed envelope in pendingMessage while it cannot push downstream. postStop did not account for it, so if the stage stopped while holding one, the envelope was neither pushed, nor sent to dead letters, nor counted by the pending-system-message quarantine safeguard in SendQueue.postStop. Modification: In postStop, send a held envelope to deadLetters and quarantine the association if it carried a SystemMessage, mirroring sendQueuePostStop in Association. Add two OutboundHandshakeSpec cases: dead-letter delivery of a pending message and quarantine for a pending system message. Result: No envelope can disappear silently when the handshake stage stops; the pending-system-message quarantine safeguard is no longer bypassed. Tests: - sbt "remote / Test / testOnly org.apache.pekko.remote.artery.OutboundHandshakeSpec": 9/9 passed - Reverted the fix and re-ran the two new tests: both failed as expected (directional) References: Fixes #3690 Report URL: https://github.com/apache/pekko/actions/runs/40109396724 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
