pjfanning opened a new pull request, #518:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/518

   ### Motivation
   The MySQL example on the Configuration page (from 
`docs/src/test/resources/application-mysql.conf`) sets 
`db-timestamp-monotonic-increasing` and `use-app-timestamp` inside 
`connection-factory`. The plugins read them from `pekko.persistence.r2dbc` 
(e.g. `journal.use-app-timestamp = 
${pekko.persistence.r2dbc.use-app-timestamp}`), so copying the example fails at 
startup with `use-app-timestamp config must be on for MySQL support`.
   
   ### Modification
   Move both settings out of `connection-factory`, directly under 
`pekko.persistence.r2dbc`.
   
   ### Result
   The documented MySQL configuration enables the settings that the MySQL 
dialect requires.
   
   ### Tests
   - Not run - docs only. As a check, I loaded the example with 
`reference.conf` and read `JournalSettings`: `use-app-timestamp` and 
`db-timestamp-monotonic-increasing` resolve to `false` with the old snippet and 
`true` with the new one.
   - `sbt docs/paradox`
   
   ### References
   Fixes #516


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to