pjfanning opened a new pull request, #522:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/522

   ### Motivation
   When `logDbCallsExceeding` is negative (`log-db-calls-exceeding = off`, or 
the `-1.millis` passed by `R2dbcSession.withSession`), `durationInMicros` 
returned `0`, so every `durationMicros >= logDbCallsExceedingMicros` check was 
true and getConnection, select and update calls were all logged at INFO.
   
   ### Modification
   Return `Long.MinValue` from `durationInMicros` when timing is disabled, 
matching akka/akka-persistence-r2dbc#328 (Apache 2.0 licensed since its change 
date).
   
   ### Result
   No per-call INFO logging when `log-db-calls-exceeding` is disabled; logging 
with a non-negative threshold is unchanged.
   
   ### Tests
   - `sbt "core/testOnly 
org.apache.pekko.persistence.r2dbc.internal.R2dbcExecutorSpec"` against 
PostgreSQL: passed. The new disabled-logging test fails without the fix.
   - `sbt core/mimaReportBinaryIssues`: passed
   
   ### References
   Fixes #521


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to