The GitHub Actions job "Validate and test" on 
pekko-http.git/server-timeouts-java-duration has failed.
Run started by GitHub user pjfanning (triggered by pjfanning).

Head commit for run:
fb6548f4630ef371c68dc50547190059f9a5b7c3 / PJ Fanning 
<[email protected]>
use java.time.Duration for ServerSettings stream cancellation delay

Motivation:
The Java DSL ServerSettings.getStreamCancellationDelay returns a Scala
FiniteDuration and withStreamCancellationDelay only accepts one, unlike
ClientConnectionSettings which moved to java.time.Duration in 2.0.0.

Modification:
Change javadsl ServerSettings.getStreamCancellationDelay to return
java.time.Duration and add a java.time.Duration overload of
withStreamCancellationDelay. Scala users keep using streamCancellationDelay.
Add MiMa excludes for the intentional 2.0.0 result type change.

Result:
Java users can read and set the server stream cancellation delay with
java.time.Duration.

Tests:
- sbt "http-core/Test/testOnly 
org.apache.pekko.http.javadsl.settings.ServerSettingsTest" - passed
- sbt http-core/mimaReportBinaryIssues - passed with the new excludes
- sbt http-core/scalafmt, http-core/Test/javafmt - no changes

References:
None - Java DSL cleanup of Scala types in public API

Report URL: https://github.com/apache/pekko-http/actions/runs/40178639992

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to