The GitHub Actions job "Validate and test" on 
pekko-http.git/pool-response-result has failed.
Run started by GitHub user pjfanning (triggered by pjfanning).

Head commit for run:
e07f7226eb943489d02a8465ad1e577e7c0059a5 / PJ Fanning 
<[email protected]>
add Java connection pool flows that emit HttpResponseResult instead of Try

Motivation:
The Java DSL host-level and super pool flows emit
Pair<scala.util.Try<HttpResponse>, T>, so Java users of the streaming client
API have to work with a Scala type. Java cannot overload on return type, so
the existing methods cannot gain Java-typed twins.

Modification:
Add javadsl HttpResponseResult, a success-or-failure holder with isSuccess,
isFailure, getResponse, getFailure, fold and handle. Add *WithResult
variants of newHostConnectionPool, cachedHostConnectionPool,
cachedHostConnectionPoolHttps and superPool (all overloads) that delegate to
the existing methods and map each Try to an HttpResponseResult. Document the
variants in the host-level client docs.

Result:
Java users can stream requests through connection pools without
scala.util.Try. The existing methods are unchanged.

Tests:
- sbt "http-core/Test/testOnly 
org.apache.pekko.http.javadsl.HttpResponseResultTest 
org.apache.pekko.http.javadsl.HttpExtensionApiSpec" - passed on 2.13 and 3.3.8
- sbt http-core/mimaReportBinaryIssues - passed
- sbt http-core/scalafmtCheckAll, http-core/Test/javafmtCheck - passed

References:
None - Java DSL cleanup of Scala types in public API

Report URL: https://github.com/apache/pekko-http/actions/runs/40187328782

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to