The GitHub Actions job "Validate and test" on pekko-http.git/host-overrides-java-pair has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run: 15d6dd34fe90966aa41d02da07343bf7e18a9d35 / PJ Fanning <[email protected]> take japi.Pair in javadsl ConnectionPoolSettings.withHostOverrides Motivation: The Java DSL ConnectionPoolSettings.withHostOverrides takes a java.util.List of scala.Tuple2, so Java users have to construct Scala tuples to configure per-host pool overrides. Modification: Change the parameter to java.util.List<pekko.japi.Pair<String, ConnectionPoolSettings>>. The method is @ApiMayChange, and an overload is not possible because both versions erase to the same signature. Order is kept, so the first matching host pattern still wins. Add a MiMa exclude for the intentional generic signature change. Result: Java users can configure host overrides with Pair.create(pattern, settings). Tests: - sbt "http-core/Test/testOnly org.apache.pekko.http.javadsl.settings.ConnectionPoolSettingsTest" - passed on 2.13 - sbt "++3.3.8" "http-core/Test/testOnly org.apache.pekko.http.javadsl.settings.ConnectionPoolSettingsTest org.apache.pekko.http.scaladsl.settings.ConnectionPoolSettingsSpec" - passed - sbt http-core/mimaReportBinaryIssues - passed with the new exclude - sbt http-core/scalafmt, http-core/Test/javafmt - no changes References: None - Java DSL cleanup of Scala types in public API Report URL: https://github.com/apache/pekko-http/actions/runs/40187789325 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
