He-Pin commented on code in PR #3710: URL: https://github.com/apache/pekko/pull/3710#discussion_r4374931829
########## stream/src/main/scala/org/apache/pekko/stream/impl/io/compression/ZstdDecompressor.scala: ########## @@ -36,6 +37,22 @@ import pekko.util.ByteString private val EmptyInput = ByteBuffer.allocate(0) private val NoInput: Iterator[ByteBuffer] = Iterator.empty + // ZstdDecompressCtx.setLongMax was added after zstd-jni 1.5.7-24 (luben/zstd-jni#431). zstd-jni is an optional + // dependency that users add themselves, so the method is looked up rather than linked against, and is used when a + // newer zstd-jni is on the classpath. + // TODO call setLongMax directly once Pekko depends on a zstd-jni release that has it (#3674) + private lazy val setLongMax: Option[Method] = Review Comment: No Refrection, use methodHandle -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
