ptrdom commented on code in PR #511:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/511#discussion_r4375590757
##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/internal/PubSub.scala:
##########
@@ -132,23 +133,25 @@ import org.slf4j.LoggerFactory
val offset = TimestampOffset(timestamp, timestamp, Map(pid ->
pr.sequenceNr))
- val (eventPayload, tags) = pr.payload match {
+ val (eventOption, tags, filtered) = pr.payload match {
case Tagged(payload, tags) =>
- (payload, tags)
+ (Some(payload), tags, false)
Review Comment:
Nit: this replaced `Option(eventPayload)` with `Some(payload)` (also on the
`other` branch), so a null payload would now become `Some(null)` instead of
`None`. That's unlikely in practice, but `Option(...)` would keep the old
behaviour.
##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/internal/PubSub.scala:
##########
@@ -132,23 +133,25 @@ import org.slf4j.LoggerFactory
val offset = TimestampOffset(timestamp, timestamp, Map(pid ->
pr.sequenceNr))
- val (eventPayload, tags) = pr.payload match {
+ val (eventOption, tags, filtered) = pr.payload match {
case Tagged(payload, tags) =>
- (payload, tags)
+ (Some(payload), tags, false)
+ case FilteredPayload =>
Review Comment:
Can a `FilteredPayload` ever reach the journal wrapped in `Tagged`? If so,
the `Tagged` case above would match first and it would still be published
unfiltered. Upstream has the same gap, so this is fine to leave if no Pekko
path produces it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
