ptrdom commented on code in PR #665:
URL: https://github.com/apache/pekko-projection/pull/665#discussion_r4377654425
##########
r2dbc/src/main/scala/org/apache/pekko/projection/r2dbc/internal/R2dbcOffsetStore.scala:
##########
@@ -413,12 +415,30 @@ private[projection] class R2dbcOffsetStore(
clearInflight()
if (newState == State.empty) {
None
+ } else if (moreThanOneProjectionKey(recordsWithKey)) {
+ // When downscaling projection instances (changing slice distribution)
there
Review Comment:
Nit: the comment says "changing slice distribution", but this branch also
applies when scaling up, since a new, narrower key reads rows written under the
wider one. Something like "When changing the number of projection instances
(slice distribution)" would cover both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
